@crazycells Agreed. It takes a more sensible approach. Nobody ever upvotes the first post - itโs usually much further down as the conversation progresses.
Post Style View
-
@phenomlab i can not understand how it can be, i do not touch anything js side.
so now everything is working and code is okey hope so?
-
@cagatay Not entirely. There is an ajax call I need to use called
action:ajaxify.loaded
but this does not seem to be firing on your site. Itโs opposite,action:ajaxify.end
works fine (as youโll see if you press F5) but the former does not, and I canโt see any reason as to why. -
@phenomlab maybe it depends on my nodebb version or really i can not say anything coz i don not know what is the ajax code as well
-
@cagatay Your NodeBB is up to date, so not an issue there. Just seems odd that no matter what I try, it doesnโt trigger. Investigating
-
@phenomlab maybe there is a problem in my vps or ubuntu is not clearlu working or library etcโฆ
-
@cagatay Not sure, but will check out a theory I have first before we go down that route.
-
@cagatay Found the issue. It appears that the hook I should be calling is in fact
action:posts.loaded
and notaction:ajaxify.loaded
Should be fixed now but take a look. The best way to test this is to find a topic with lots of posts, and scroll to the bottom. Then, reload the page, and start scrolling up from the bottom to the top. As the new posts are added into the DOM, that function I wrote should execute and add the missing
class
For anyone else following this thread, the two required
jQuery
functions are$(window).on('action:posts.loaded', function(data) { $(document).ready(function() { if ($('li[component="post"]').hasClass("")) { console.log("New posts detected,so adding classes for messenger type view"); $('li[component="post"]').addClass('topic-response-post'); } }); }); $(window).on('action:ajaxify.end', function(data) { $(document).ready(function() { if ($('li[component="post"]').hasClass("")) { console.log("Adding required classes for messenger type view"); $('li[component="post"]').addClass('topic-response-post'); } }); });
-
@phenomlab i checked topic with a lots of posts 3 times everything is clear and very well now. thank you your effort.
-
@cagatay No problems. Glad itโs all working. I need to document this for others to be able to use.
-
@phenomlab said in Post Style View:
@cagatay No problems. Glad itโs all working. I need to document this for others to be able to use.
this post is very good document for the users who will want to use it
-
@cagatay Yes, but I want to create something more concise and simpler to follow
-
-
@cagatay in case youโre still following this thread, I found a far more efficient way of adding the classes using
jQuery
. To this end, you can change this block above with this code// Target those elements already loaded in the DOM $(document).ready(function() { $(window).on('action:ajaxify.end', function(data) { $('li[component="post"]').each(function(i, obj) { if (!$(this).hasClass('self-post') || (!$(this).hasClass('self-post'))) { console.log("Adding required classes for messenger type view"); $(this).addClass('topic-response-post'); } }); }); }); // Target elements dynamically added to the DOM on post load $(document).ready(function() { $(window).on('action:ajaxify.loaded', function(data) { $('li[component="post"]').each(function(i, obj) { if (!$(this).hasClass('self-post') || (!$(this).hasClass('self-post'))) { console.log("Adding required classes for messenger type view"); $(this).addClass('topic-response-post'); } }); }); });
-
@phenomlab said in Post Style View:
// Target those elements already loaded in the DOM
$(document).ready(function() {
$(window).on(โaction:ajaxify.endโ, function(data) {
$(โli[component=โpostโ]โ).each(function(i, obj) {
if (!$(this).hasClass(โself-postโ) || (!$(this).hasClass(โself-postโ))) {
console.log(โAdding required classes for messenger type viewโ);
$(this).addClass(โtopic-response-postโ);
}}); });
});
// Target elements dynamically added to the DOM on post load
$(document).ready(function() {
$(window).on(โaction:ajaxify.loadedโ, function(data) {
$(โli[component=โpostโ]โ).each(function(i, obj) {
if (!$(this).hasClass(โself-postโ) || (!$(this).hasClass(โself-postโ))) {
console.log(โAdding required classes for messenger type viewโ);
$(this).addClass(โtopic-response-postโ);
}}); });
});
thank you Mark.
changed it. -
@phenomlab there is small problem after revised codes which you shared.
problem is shown below; answered nick and labels nested. -
@cagatay thatโs just a margin missing. The code I provided wonโt be causing that. If you look for the element in the developers console and add a
margin-left
value to it, that should resolve it. -
@phenomlab may i use this code?
.topic-owner-post [itemprop="author"] { float: left; } // Add these to (or edit) the existing classes you have .user-level-topic { float: none; } .group-label { margin-top: -1px; } .topic-owner-post [itemprop="author"]:after { margin-top: 1px; height: 18px; }
-
@cagatay from the screenshot you provided, it looks like youโve used them. They are fine to use, but you are missing a couple of styles.
Iโll have a look at this tomorrow and give you the remainder of the code you need.
-
@phenomlab i cant fix it
-
Just add margin-left on the element like @phenomlab said to you :
topic [component="post/parent"] { margin-left: 10px; }
Maybe @phenomlab have a better way