Skip to content

Theme retirement

Announcements
  • Personally I prefer to have the choice and maintaining the themes is even easier than before with the SCSS
    Having the choice of only light and dark is a bit gloomy.

    Personnaly I like less than the others summertime and tenebrous

  • phenomlabundefined phenomlab forked this topic on
  • Something of an update here, and I haven’t forgotten about this topic. It’s still very much on the radar, and in fact, I’m working on replacing the theme structure to make it a bit more modern.

    It’s going to be based on Google’s Material Design, so something of an industry standard. Taking this approach seems to make more sense and in the process, I’ve been extending the theme capabilities to allow for a better look overall.

    The overall impact of this is that I can then use a “skeleton” or framework to create other themes and swatches.

    If you want to try the latest theme, it’s “Material” under the light section. However, please be warned that there are a number of bugs that will only show themselves once you flip back to one of the existing ones, and to resolve that, you’ll need to reload the browser (F5 for example).

    The downside is that I’ll need to recreate the themes I want to include from scratch… 😥

  • A significant update…

    I’ve been working away on the new theme, and would like some testers (those using light themes for now such as flatly are perfect). If you do test, it should be from both mobile and desktop if possible.

    There are a number of changes to the architecture of this specific theme as I noted in the previous post, and because of that, switching themes may produce some undesirable results temporarily until the other themes are modified as required.

    On that front, I’ve made the decision to retire most of the themes. For those using light themes such as the default, this will be replaced with the material light theme and will be the “stock” theme going forward if you are using a light theme on your device. There will be another two themes, which will be dim and dark in terms of category.

    Whilst this might be disappointing for some users, let me explain. Even though the theme switcher handles the changing of colours etc, there is a significant amount of work that goes on in the background in terms of some components that need to be rendered again after the theme changes - this is done in the background so you’ll never see it - the trigger is the loading of a topic for example, so changed are executed against the DOM during the ajax call for data. I don’t know if you’ve noticed, but there is an animation delay when loading data, so I use that as a way of refreshing new elements so the end user never sees it.

    However, one drawback is that the stale and unused elements remain in the DOM which increases it’s size, and this will be detrimental to the loading experience if the theme is changed several times in the same session without reloading the browser. Rewriting the theme enabled me to address this issue, and because of that, I’ll be reducing the available themes down to probably three as a result - maybe four if there is a specific theme that is popular (you’ll need to let me know if this is the case).

    If you are using the theme switcher code from git then you don’t need to worry about performance on your own site as this code was released well before the changes to the DOM (required by the new themes) and is not impacted at all.

    I’ve not released the new code and probably won’t until I’m happy with the way it works. Presently, there are a number of issues that need to be resolved before I’ll even consider making it available for use on other forums.

  • Here’s some teaser screenshots. It’s not finished yet, but well, here goes

    image.png

    image.png

    4edf93d4-1c84-44c8-b4fe-eba1a30879de-image.png

  • I liked this… is this number of topics?

    Screen Shot 2023-08-10 at 16.12.57.png

  • additionally, the amplifying circle is not centered on profile pages, FYI…

    Screen Shot 2023-08-10 at 16.13.50.png

  • the person who sends the last post are usually seen as avatar, however in large screen it is lost, is this intentional?

    Screen Shot 2023-08-10 at 16.19.40.png
    Screen Shot 2023-08-10 at 16.20.06.png

  • @crazycells yes, it’s actually not my work but someone on the NodeBB forums. I’ll dig out the link.

  • @crazycells thanks. I’ve never been able to reproduce this so will have to look at it again.

  • @crazycells no. That’s probably the result of me using targeted CSS to disable the appearance of something else and inadvertently over compensating. I’ll take a look.

  • @crazycells You’ll notice some odd looking artefacts like borders and inset box shadows being used.

    I’m going to be removing the legacy themes tomorrow so this problem will resolve itself, but for the full effect, you should select “Material” in the light section. If you switch back to a previous legacy theme afterwards, you’ll need to reload the browser.

  • @crazycells No problem. it’s also worth noting that I rewrote some of the widget code to include links for each category as these are missing from the original. Here’s the revised code

    <style>
    .stats-info.text-sm.mt-1.mb-3 {
        text-align: center;
    }
    </style>
    <div id="stats-pro">
     
    <div class="progress mt-4 stats-bar" style="height: 8px;">
    {{{ each categories }}}
    <div class="progress-bar-github" role="progressbar" style="width: {./totalTopicCount}%;background-color: {./bgColor};" aria-valuemin="0" aria-valuemax="100"></div>
    {{{ end }}}
    </div>
     
    <div class="stats-info text-sm mt-1 mb-3">
    {{{ each categories }}}
    <a href="/category/{./cid}/{./name}"><span class="mb-3 me-2 fw-semibold text-nowrap"><i class="fa fa-fw fa-solid fa-2xs fa-circle" style="color: {./bgColor};font-weight: 900;"></i> {./name}</a><span class="text-xs text-muted">({./totalTopicCount})</span></span>
    {{{ end }}}
    </div>
     
    </div>
    
    
  • @crazycells Thought it might 🙂

  • phenomlabundefined phenomlab referenced this topic on
  • @crazycells said in Theme retirement:

    the person who sends the last post are usually seen as avatar, however in large screen it is lost, is this intentional?

    That was an unintended bug (thanks) which I’ve just fixed. I was using the below CSS to hide images in the teaser view as below

        .meta.teaser img, .meta.teaser blockquote  {
            display: none;
        }
    

    However, this had the undesired effect of removing the user avatar (which I want to keep obviously), so am now using this CSS

        .meta.teaser img:not(.avatar), .meta.teaser blockquote  {
            display: none;
        }
    
  • I relented somewhat here and added another swatch - one I missed, which was previous called “blackout”. This specific one has been adapted to work on the new theming engine, but the others have been reclassified, and renamed to suit.

    image.png

    As a result, the theme you might have had will probably be reflecting something else, so you (might) need to change your themes accordingly. The changes are as follows

    Light -> No Change
    Cloudy -> Is now the old “Dim”
    Dim -> Is now the old “Dark”
    Dark -> Now a new theme based on the revamped “Blackout”


Related Topics