nodebb-plugin-reactions not working @v1.0.2 with Harmony theme

[dave1904]

@phenomlab

At the moment I try it the other way around so avoid downtime on prod: Activating plugins on dev to see if reactions stops working. Will keep you updated!

[phenomlab]

@dave1904 ok but I think you might need the steps I provided in previous posts in this thread.

[dave1904]

@phenomlab A complete reset feels a bit like an overkill for one plugin not working which, as julian I think mentioned, could be re-developed soon. But the plugin keeps active on dev, even after activating many plugins again.

[phenomlab]

@dave1904 said in nodebb-plugin-reactions not working @v1.0.2 with Harmony theme:

@phenomlab A complete reset feels a bit like an overkill for one plugin not working which, as julian I think mentioned, could be re-developed soon. But the plugin keeps active on dev, even after activating many plugins again.

Yes, I agree, but I didn’t mean that - sorry.

What I meant was using

npm config set legacy-peer-deps true

On prod and running the /nodebb upgrade to see if that helps.

[dave1904]

@phenomlab Thanks for reminding me on this one. I just tried that but still no success.

[phenomlab]

@dave1904 what was the output of the upgrade? Did it complain about any missing dependencies?

[dave1904]

@phenomlab

I couldn’t see that:

Updating NodeBB...

1. Updating package.json file with defaults...  OK

2. Bringing base dependencies up to date...  started

up to date, audited 1113 packages in 7s

131 packages are looking for funding
  run `npm fund` for details

13 vulnerabilities (7 moderate, 6 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

3. Checking installed plugins for updates...Checking installed plugins and themes for updates...   OK

A total of 1 package(s) can be upgraded:

  * nodebb-plugin-question-and-answer (1.0.17 -> 1.0.18)

Proceed with upgrade (y|n)? y

Upgrading packages...

4. Updating NodeBB data store schema...
Parsing upgrade scripts... 
OK | 0 script(s) found, 125 skipped
Schema update complete!


5. Rebuilding assets...  started
2023-05-01T21:02:24.095Z [4567/261222] - info: [build] Building in series mode
2023-05-01T21:02:24.096Z [4567/261222] - info: [build]         plugin static dirs  build started
2023-05-01T21:02:24.105Z [4567/261222] - info: [build]         plugin static dirs  build completed in 0.009sec
2023-05-01T21:02:24.106Z [4567/261222] - info: [build]          requirejs modules  build started
2023-05-01T21:02:24.254Z [4567/261222] - info: [build]          requirejs modules  build completed in 0.148sec
2023-05-01T21:02:24.254Z [4567/261222] - info: [build]           client js bundle  build started
2023-05-01T21:02:24.259Z [4567/261222] - info: [build]           client js bundle  build completed in 0.005sec
2023-05-01T21:02:24.260Z [4567/261222] - info: [build]            admin js bundle  build started
2023-05-01T21:02:24.261Z [4567/261222] - info: [build]            admin js bundle  build completed in 0.001sec
2023-05-01T21:02:24.261Z [4567/261222] - info: [build]         client side styles  build started
Deprecation Warning on line 68, column 52 of node_modules/bootswatch/dist/flatly/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
68 │ $nav-link-padding-y:                .5rem !default !default;
   │                                                    ^^^^^^^^
   ╵

Deprecation Warning on line 70, column 56 of node_modules/bootswatch/dist/flatly/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
70 │ $nav-link-disabled-color:           $gray-600 !default !default;
   │                                                        ^^^^^^^^
   ╵

2023-05-01T21:02:30.523Z [4567/261222] - info: [build]         client side styles  build completed in 6.262sec
2023-05-01T21:02:30.524Z [4567/261222] - info: [build] admin control panel styles  build started
2023-05-01T21:02:35.223Z [4567/261222] - info: [build] admin control panel styles  build completed in 4.698sec
2023-05-01T21:02:35.226Z [4567/261222] - info: [build]                  templates  build started
2023-05-01T21:02:36.223Z [4567/261222] - info: [build]                  templates  build completed in 0.997sec
2023-05-01T21:02:36.223Z [4567/261222] - info: [build]                  languages  build started
2023-05-01T21:02:39.308Z [4567/261222] - info: [build]                  languages  build completed in 3.085sec
2023-05-01T21:02:39.309Z [4567/261222] - info: [build] Bundling with Webpack.
2023-05-01T21:03:07.379Z [4567/261222] - info: [build] Bundling took 23607 ms
2023-05-01T21:03:07.394Z [4567/261222] - info: [build] Asset compilation successful. Completed in 43.284sec.


                                            NodeBB Upgrade Complete!

[phenomlab]

@dave1904 yes, that looks clean. On prod, could you provide the output of

./nodebb plugins

I’m specifically interested in the version numbers of the emoji and reactions plugins. However, as dev is a replica of prod, I suspect the same “fix” (as heavy handed as it is) is needed for prod.

However, I do agree that this approach isn’t desirable for obvious reasons.

[dave1904]

Yes, I also have that bad feeling only reset would help. Anyway here is the output:

Active plugins:
        * @nodebb/nodebb-plugin-reactions@1.0.2 (installed, enabled)
        * nodebb-plugin-2factor@7.0.5 (installed, disabled)
        * nodebb-plugin-beep@0.4.7 (installed, disabled)
        * nodebb-plugin-composer-default@10.0.48 (installed, enabled)
        * nodebb-plugin-contact-page@1.3.0 (installed, disabled)
        * nodebb-plugin-custom-pages@2.0.3 (installed, enabled)
        * nodebb-plugin-customize@3.0.0 (installed, disabled)
        * nodebb-plugin-dbsearch@6.0.0 (installed, enabled)
        * nodebb-plugin-email-blacklist@2.0.0 (installed, disabled)
        * nodebb-plugin-emoji@5.0.6 (installed, enabled)
        * nodebb-plugin-emoji-android@4.0.0 (installed, disabled)
        * nodebb-plugin-emoji-one@4.0.0 (installed, enabled)
        * nodebb-plugin-emoji-vital@4.0.0 (installed, disabled)
        * nodebb-plugin-markdown@12.0.2 (installed, enabled)
        * nodebb-plugin-mentions@4.1.0 (installed, enabled)
        * nodebb-plugin-newsletter@0.10.2 (installed, disabled)
        * nodebb-plugin-night-mode@1.0.7 (installed, disabled)
        * nodebb-plugin-ns-likes@3.0.0 (installed, disabled)
        * nodebb-plugin-ntfy@1.0.15 (installed, disabled)
        * nodebb-plugin-poll@3.0.4 (installed, enabled)
        * nodebb-plugin-question-and-answer@1.0.18 (installed, enabled)
        * nodebb-plugin-recent-cards@3.1.11 (installed, enabled)
        * nodebb-plugin-shoutbox@2.0.4 (installed, disabled)
        * nodebb-plugin-spam-be-gone@2.0.6 (installed, enabled)
        * nodebb-plugin-tenor-gif@3.0.0 (installed, enabled)
        * nodebb-plugin-youtube-embed@0.6.9 (installed, enabled)
        * nodebb-rewards-essentials@0.2.3 (installed, enabled)
        * nodebb-theme-harmony@1.0.1 (installed, enabled)
        * nodebb-theme-lavender@7.0.9 (installed, disabled)
        * nodebb-theme-peace@2.0.19 (installed, disabled)
        * nodebb-theme-persona@13.0.56 (installed, disabled)
        * nodebb-theme-slick@2.0.2 (installed, disabled)
        * nodebb-theme-vanilla@12.1.19 (installed, disabled)
        * nodebb-widget-essentials@7.0.9 (installed, enabled)
        * nodebb-widget-ns-stats@3.0.0 (installed, disabled)

[phenomlab]

Instead of a complete reset, would you be open to disabling all plugins apart from the stock ones, plus emoji, emoji android, and reactions?

Obviously you’ll need to perform a rebuild and restart.

[dave1904]

Do you know if I would have to reconfigure all the disabled plugins?

[phenomlab]

@dave1904 no, that won’t be necessary. Disabling them means that they won’t be loaded, but will keep their settings.

[dave1904]

@phenomlab Yes I just thought I could have checked that myself on dev Yes I would try that but is there a list of the stock plugins?

[phenomlab]

@dave1904 umm. That’s a good question. I’m not sure there is. Let’s start with the below

@nodebb/nodebb-plugin-reactions
nodebb-plugin-composer-default
nodebb-plugin-emoji
nodebb-plugin-emoji-android
nodebb-plugin-markdown
nodebb-plugin-mentions
nodebb-theme-harmony

If reactions starts playing ball, then we enable the other extensions.

[dave1904]

@phenomlab Thanks. I will try it tomorrow as it’s already late here

[phenomlab]

@dave1904 yep. You know where I am if you need me.

[phenomlab]

@dave1904 just checking in - any joy ?

[dave1904]

Hi @phenomlab , I just disabled all the plugins except the mentioned ones, rebuilt and restarted the forum but still the plugin doesn’t fire. I guess I really have to reset the forum then.

[phenomlab]

@dave1904 sadly, yes, seems there’s no other viable route here.

[dave1904]

@phenomlab Yes but for me that’s not worth it, I would rather try to develop a new plugin (featuring notifications) hehe.