Post Style View

[phenomlab]

@cagatay said in Post Style View:

maybe it depends on me or my web browser. thank you

One thing I have noticed is that there are a number of errors on your site in the console. My concern here is that the jQuery functions I added are not being executed. For example, I removed the below function from your site about 30 minutes ago because it’s malformed

});ment).ready(function () {
    function animateTags() {
    	if (ajaxify.data.template.name === 'categories') {
    		var tags = $('.popular-tags .tag-item');
    		var bar = $('<div class="popular-tags-bar"></div>');
    		tags.append(bar);
    		
    		var max;
    		
    		setTimeout(function() {
        		tags.each(function() {
        		   var bar = $(this).find('.popular-tags-bar');
        		   var val = parseInt(bar.parents('a').find('.tag-topic-count').text(), 10);
        		   max = max > val ? max : val;
        		   
        		   bar.css({
        		       width: val / max * 100 + '%'
        		   });
        		});
    		}, 100)
    	}
    }
    animateTags();
    $(window).on('action:ajaxify.end', animateTags);
});

As you can see, this isn’t right at all. It should be

$(document).ready(function () {
    function animateTags() {
        if (ajaxify.data.template.name === 'categories') {
            var tags = $('.popular-tags .tag-item');
            var bar = $('<div class="popular-tags-bar"></div>');
            tags.append(bar);
 
            var max;
 
            setTimeout(function () {
                tags.each(function () {
                    var bar = $(this).find('.popular-tags-bar');
                    var val = parseInt(bar.parents('a').find('.tag-topic-count').text(), 10);
                    max = max > val ? max : val;
 
                    bar.css({
                        width: val / max * 100 + '%'
                    });
                });
            }, 100);
        }
    }
    animateTags();
    $(window).on('action:ajaxify.end', animateTags);
});

I’ve put this back how it should be, but am curious as to where that came from.

[cagatay]

@phenomlab i can not understand how it can be, i do not touch anything js side.

so now everything is working and code is okey hope so?

[phenomlab]

@cagatay Not entirely. There is an ajax call I need to use called action:ajaxify.loaded but this does not seem to be firing on your site. It’s opposite, action:ajaxify.end works fine (as you’ll see if you press F5) but the former does not, and I can’t see any reason as to why.

[cagatay]

@phenomlab maybe it depends on my nodebb version or really i can not say anything coz i don not know what is the ajax code as well

[phenomlab]

@cagatay Your NodeBB is up to date, so not an issue there. Just seems odd that no matter what I try, it doesn’t trigger. Investigating

[cagatay]

@phenomlab maybe there is a problem in my vps or ubuntu is not clearlu working or library etc…

[phenomlab]

@cagatay Not sure, but will check out a theory I have first before we go down that route.

[phenomlab]

@cagatay Found the issue. It appears that the hook I should be calling is in fact action:posts.loaded and not action:ajaxify.loaded

Should be fixed now but take a look. The best way to test this is to find a topic with lots of posts, and scroll to the bottom. Then, reload the page, and start scrolling up from the bottom to the top. As the new posts are added into the DOM, that function I wrote should execute and add the missing class

For anyone else following this thread, the two required jQuery functions are

    $(window).on('action:posts.loaded', function(data) {
        $(document).ready(function() {
        if ($('li[component="post"]').hasClass("")) {
            console.log("New posts detected,so adding classes for messenger type view");
            $('li[component="post"]').addClass('topic-response-post');
        }
    });
});
    $(window).on('action:ajaxify.end', function(data) {
        $(document).ready(function() {
        if ($('li[component="post"]').hasClass("")) {
            console.log("Adding required classes for messenger type view");
            $('li[component="post"]').addClass('topic-response-post');
        }
    });
});

[cagatay]

@phenomlab i checked topic with a lots of posts 3 times everything is clear and very well now. thank you your effort.

[phenomlab]

@cagatay No problems. Glad it’s all working. I need to document this for others to be able to use.

[cagatay]

@phenomlab said in Post Style View:

@cagatay No problems. Glad it’s all working. I need to document this for others to be able to use.

this post is very good document for the users who will want to use it

[phenomlab]

@cagatay Yes, but I want to create something more concise and simpler to follow

[phenomlab]

@cagatay in case you’re still following this thread, I found a far more efficient way of adding the classes using jQuery. To this end, you can change this block above with this code

// Target those elements already loaded in the DOM
$(document).ready(function() {
    $(window).on('action:ajaxify.end', function(data) {
        $('li[component="post"]').each(function(i, obj) {
            if (!$(this).hasClass('self-post') || (!$(this).hasClass('self-post'))) {
                console.log("Adding required classes for messenger type view");
                $(this).addClass('topic-response-post');
            }
 
        });
    });
});
// Target elements dynamically added to the DOM on post load
$(document).ready(function() {
    $(window).on('action:ajaxify.loaded', function(data) {
        $('li[component="post"]').each(function(i, obj) {
            if (!$(this).hasClass('self-post') || (!$(this).hasClass('self-post'))) {
                console.log("Adding required classes for messenger type view");
                $(this).addClass('topic-response-post');
            }
 
        });
    });
});

[cagatay]

@phenomlab said in Post Style View:

// Target those elements already loaded in the DOM
$(document).ready(function() {
$(window).on(‘action:ajaxify.end’, function(data) {
$(‘li[component=“post”]’).each(function(i, obj) {
if (!$(this).hasClass(‘self-post’) || (!$(this).hasClass(‘self-post’))) {
console.log(“Adding required classes for messenger type view”);
$(this).addClass(‘topic-response-post’);
}

    });
});
 

});
// Target elements dynamically added to the DOM on post load
$(document).ready(function() {
$(window).on(‘action:ajaxify.loaded’, function(data) {
$(‘li[component=“post”]’).each(function(i, obj) {
if (!$(this).hasClass(‘self-post’) || (!$(this).hasClass(‘self-post’))) {
console.log(“Adding required classes for messenger type view”);
$(this).addClass(‘topic-response-post’);
}

    });
});
 

});

thank you Mark.
changed it.

[cagatay]

@phenomlab there is small problem after revised codes which you shared.
problem is shown below; answered nick and labels nested.

[phenomlab]

@cagatay that’s just a margin missing. The code I provided won’t be causing that. If you look for the element in the developers console and add a margin-left value to it, that should resolve it.

[cagatay]

@phenomlab may i use this code?

.topic-owner-post [itemprop="author"] {
    float: left;
}
// Add these to (or edit) the existing classes you have
.user-level-topic {
    float: none;
}
.group-label {
    margin-top: -1px;
}
.topic-owner-post [itemprop="author"]:after {
    margin-top: 1px;
    height: 18px;
}

[phenomlab]

@cagatay from the screenshot you provided, it looks like you’ve used them. They are fine to use, but you are missing a couple of styles.

I’ll have a look at this tomorrow and give you the remainder of the code you need.

[cagatay]

@phenomlab i cant fix it

[DownPW]

@cagatay

Just add margin-left on the element like @phenomlab said to you :

topic [component="post/parent"] {
    margin-left: 10px;
}

Maybe @phenomlab have a better way