[NODEBB] Help for my custom CSS

[phenomlab]

@DownPW In that case, change the container code to

<div id="onlineusers">{{body}}</div>

And same CSS class

div#onlineusers {
    justify-content: center;
    display: flex;
}

Then add padding and margin to suit

[DownPW]

Perfect my friend

[DownPW]

Hello mark

I wanted for test purposes, to put the welcome message in the Brand menu in the header widget.

I commented in the footer widget the corresponding code then I added it in my brand header widget:

<span id="thisuser" class="getUsername">, &nbsp;<a href="/me"><span class="username">DownPW</span></a></span>

I commented out the old CSS to add the new:

/* Welcome Message Username on Header */
span#thisuser {
     margin-top: 0.7rem;
     margin-left: 2px;
     margin-right:-2px;
     font-size: .875rem;
     line-height: 1.4rem;
     font-weight: 500;
}

So far everything is fine, the result is correct :

But as soon as I select links in the left sidebar (home, recent, etc …), the message is added and displayed as many times as I select a link .

Did I miss something or do you have an idea to solve this bug?

Thanks my friend

[phenomlab]

@DownPW sorry for the delay. That is being caused by ajax which is adding another element each time data is being called. I’d need to see the entire code block where you are adding this to confirm, but from the video you provided, that’s typically caused by the above.

You only need that specific function to run once at page load - it’s running each time data is being requested which explains the additions.

[DownPW]

it’s just the brand HTML header widget, just add this code to him

<span id="thisuser" class="getUsername">,  <a href="/me"><span class="username">DownPW</span></a></span>]

What do you want ? The HTML header widget on welcome message JS code ?

EDIT : All code in PM

[phenomlab]

@DownPW thanks. Can you try a theory for me and change that code so it looks like the below

<span id="thisuserbrand" class="getUsername">,  <a href="/me"><span class="username">DownPW</span></a></span>

I expect this to return nothing, which will prove my theory around the Ajax calls.

[DownPW]

Nope @phenomlab

Same things, same problem

[phenomlab]

@DownPW then the problem isn’t the existing function. That ID I provided doesn’t exist anywhere and isn’t tied to any elements so should never trigger.

[DownPW]

oups don’t know why I have used this code, replace by :

<div class="getUsername">, <a href="/me"><span class="username"></span></a></div>

But same problem

[phenomlab]

@DownPW did you remove the original line from the footer before placing it in the brand header?

[DownPW]

remove no, but commented like this

<!-- <span id="thisuser" class="getUsername">,  <a href="/me"><span class="username">DownPW</span></a></span> -->

EDIT: test with remove = same

[phenomlab]

@DownPW can you send me the footer function your are using. I’m 100% certain this is being caused by the ajax call.

[phenomlab]

@DownPW can you change the top line of this function from

$(window).on('action:ajaxify.end', function (data) {

To

$(document).ready() {

Save and let me know if this changes anything. The theory here is that the Ajax call in the top line causes the prepend to be executed multiple times

[DownPW]

the code doesn’t work with this

[phenomlab]

@DownPW it should work once at least on site reload, no? Or does it crash?

[DownPW]

no, doesn’t work and break theme and swatch applet

[phenomlab]

@DownPW that shouldn’t cause the error you are seeing there. It looks like that is from the previous function.

[DownPW]

the previous function is just fancybox and nothing more :

// Fancybox Media Reader
if (top.location.pathname !== '/login') {
    $(window).on('action:posts.loaded', function(data) {
        console.log("Polling DOM for lazyLoaded images to apply Fancybox");
        $(document).ready(function() {
            $('a').not('.forum-logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
                $('a[href*=".jpg"], a[href*=".jpeg"], a[href*=".png"], a[href*=".gif"], a[href*=".webp"]').addClass("noanimate");
            });
        });
    });
}

if (top.location.pathname !== '/login') {
    $(document).ready(function() {
        $(window).on('action:ajaxify.end', function(data) {
            this.$('a').not('.forum-logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
                $('a[href*=".jpg"], a[href*=".jpeg"], a[href*=".png"], a[href*=".gif"], a[href*=".webp"]').addClass("noanimate");
                data.preventDefault()
                // Strip out the images contained inside blockquotes as this looks nasty :)
                $('blockquote img').remove();
            });
            Fancybox.bind(
                'a[href*=".jpg"], a[href*=".jpeg"], a[href*=".png"], a[href*=".gif"], a[href*=".webp"]', {
                    groupAll: true,
                }
            );
        });
    });
}

// Chat fancybox - fires when chat module loaded and AJAX calls new chat
$(document).ready(function() {
    $(window).on('action:chat.loaded', function(data) {
            this.$('img').not('.forum-logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
                var newHref = $(this).attr("src");
                $(this).wrap("<a class='fancybox' href='" + newHref + "'/>");
                $('a[href*=".jpg"], a[href*=".jpeg"], a[href*=".png"], a[href*=".gif"], a[href*=".webp"]').addClass("noanimate");
                data.preventDefault();
                // Strip out the images contained inside blockquotes as this looks nasty :)
                $('blockquote img').remove();
            });
            Fancybox.bind(
                'a[href*=".jpg"], a[href*=".jpeg"], a[href*=".png"], a[href*=".gif"], a[href*=".webp"]', {
                    groupAll: true,
                }
            );
    });
});

the error above just appear wit hthe change of $(document).ready() {, no error with $(window).on('action:ajaxify.end', function (data) {

[phenomlab]

@DownPW very odd. I’ll have a look at this directly on your dev site tomorrow morning to see why this is.

EDIT - this is now fixed. I looked at the code, and I was right that it should work, and only execute once - not sure what happened there.

EDIT2 - I absolutely love this design, and am stealing it Such a clever way of depicting colour in the theme, and I’m going to make it dynamic also so that the colours change if the theme css does.

[DownPW]

@phenomlab said in [NODEBB] Help for my custom CSS:

EDIT - this is now fixed. I looked at the code, and I was right that it should work, and only execute once - not sure what happened there.

️ hmmm not, almost fixed @phenomlab !
It’s ok for duplicate ajax problem but not fixed for the the footer image : It’s appear one time and if you go to another section (like recent or unread for example), the image on footer don’t appear
Same in incognito mode.

@phenomlab said in [NODEBB] Help for my custom CSS:

EDIT2 - I absolutely love this design, and am stealing it Such a clever way of depicting colour in the theme, and I’m going to make it dynamic also so that the colours change if the theme css does.

Thank you !
–> I already told you, my code is your code

Thinking about it, I found this idea elsewhere but I don’t really know where
I just added a rotation effect on it and adapted it to the dropdown of the brand menu widget.

---

You talk about making it dynamic but I don’t really see what you mean since the theme colors represented do not change.
Unless you want to automate it. Genre detects the 2 main color types of the theme according to 2 values/declarations present in the css file.