@phenomlab thank you very much for the assistance Mark, massively appreciated as always.
The great thing about this is it’s all documented for other NodeBB users that come looking for solutions 😃.
Looks far better 🤝👍🏻.
I don’t know, I just see that OG proxy does not format the links when my code to block domains is active.
If I disable it, OG proxy works fine.
I would have to make sure that OG proxy does not activate when a blacklist link is detected or that it works one after the other
Actually I don’t really know at the moment.
EDIT:
Maybe add an ignore list to OG PROXY
@DownPW said in Block Domain:
I don’t know, I just see that OG proxy does not format the links when my code to block domains is active.
This just means that the callback / hook isn’t monitored by OGProxy and can probably be quite easily rectified.
@DownPW said in Block Domain:
Maybe add an ignore list to OG PROXY
There is one already in function.js
- see below
https://github.com/phenomlab/ogproxy/blob/03d5ff125611361700d785bd82a6ab16fcd68bfc/function.js#L9
In any case, it doesn’t change anything in fact I think to add exclusions in OG Proxy, because links which are not to be ignored are not formatted by OG proxy
@phenomlab said in Block Domain:
This just means that the callback / hook isn’t monitored by OGProxy and can probably be quite easily rectified.
I’ll look and try to figure it out but can you help me with this ?
@DownPW said in Block Domain:
I’ll look and try to figure it out but can you help me with this ?
Yes, of course.
no luck for now
@DownPW Can you provide a summary of what you’ve tried?
I don’t have everything listed.
In fact I’m trying to understand what’s going on, otherwise I’m going all over the place but I don’t have any errors in the console.
In fact I have the impression that the 2 codes act on <a> and that they sometimes come into conflict because when I enter the topic via the recent page or other, OG proxy does the job, I refresh, it works again , I refresh and the OGproxy does nothing.
I have the impression that both codes are playing with the DOM and it’s not okay.
Sometimes OGproxy works, sometimes it works on every second link, and sometimes not at all.
Anyway, I’m a little lost at the moment.
I don’t really know what changed or what script changed.
@DownPW I don’t think this is OGProxy. I think it’s your script that manipulates the DOM afterwards and causes the issue. Is there somewhere I can see the script and review it (dev) ?
Script is on dev yes.
@DownPW is OGProxy also on dev? I’ll need both running
Yes ogproxy too is functionnal on dev