@DownPW said in Threaded chat support for NodeBB:
Better like this : add shadow and border-left on self answer
Of course - you style to your own requirements and taste 🙂 I’ll commit that CSS we discussed yesterday also
indeed it is better but it also modifies the result on 1 line…
As you say, we can’t do much until the plugin is modified
@DownPW Yes, it’s not very elegant sadly, and there is an impact to other elements. You could write a jQuery function that only modifies the CSS when there are more than x of the same element in that div
…
Why not @phenomlab but like you know, i’m not a good JS develloper lol
I have not the skills for that
@phenomlab do you think it is difficult to do?
@DownPW said in nodebb chat roll dice game:
do you think it is difficult to do?
No, but judging by this
https://github.com/NodeBB/NodeBB/pull/10837/commits/e7404fd7c3d401e6adb6246c23e5567cda136dec
It might be best to wait - or if you can’t, you could easily patch that file, or overwrite it (public/src/modules/helpers.common.js
)
@phenomlab said in nodebb chat roll dice game:
It might be best to wait - or if you can’t, you could easily patch that file, or overwrite it
ok but I don’t understand what the correction do for my problem ?
The interpretation of HTML is better ?
@DownPW yes, exactly. It’ll enable better element styling meaning a greater flexibility in terms of being able to target specific components
I will test to see if it’s better out of curiosity but I don’t think that will be enough…
That is what I thought. patching the file is not enough. Same result
@DownPW did you rebuild and restart after patching?
@DownPW from what I’ve read, the patch appears in core v2.5.0
and even then, this plugin would still need to be modified so that targeting classes is then available.
Yes I see that and the correctif with type event ID
@DownPW I still think you could do something much quicker with jQuery.
@phenomlab said in nodebb chat roll dice game:
@DownPW I still think you could do something much quicker with jQuery.
Why not but like I said, I have no skills to do that.
If you are motivated, why not but I don’t want to bother you especially since it will only be for a certain period of time.