nodebb chat roll dice game

[phenomlab]

@DownPW sounds like the plugin author is responsive and open to requests etc. I think taking this route is going to be quicker, but happy to review of you think otherwise.

[DownPW]

Nope no problem mark @phenomlab

I have another request that should take less time for you.

I open it in another thread.

[DownPW]

@phenomlab said in nodebb chat roll dice game:

@DownPW sounds like the plugin author is responsive and open to requests etc. I think taking this route is going to be quicker, but happy to review of you think otherwise.

[DownPW]

hi @phenomlab

Have you got an idea for improve that bug ? :

Hello @oplik0

It’s appear when the result of a roll appear on 2 lines in the timeline (Example: lot of dice roll)

Example here with no bugs on 1 line :

thanks for your futur replies

[phenomlab]

@DownPW is there a url where I can see this ?

[DownPW]

@phenomlab

You can test on my VM test as usual
MP

[DownPW]

@phenomlab

I have test some CSS code but it’s difficult for me.

I just manage to remove the span time but it also removes it for other system events appearing on the timeline.

span.timeago.timeline-text {
    display: none;
}

I can’t figure out why the username and timestamp display correctly on one line and not on 2. It’s almost the same thing finally

[phenomlab]

@DownPW This isn’t going to be a simple fix you can resolve with CSS. The issue here is how the plugin injects new code into an existing HTML structure, but doesn’t provide any means of identifying elements by ID rather than using a shared class name. Based on this, “best effort” is all that can be offered without directly changing any code.

For example

.dice-event-text {
    display: inline-block;
    align-items: center;
    flex-wrap: wrap;
    max-width: 800px;
    width: 800px;
}

This yields

Not perfect of course, but certainly better than what you have.

[DownPW]

indeed it is better but it also modifies the result on 1 line…

As you say, we can’t do much until the plugin is modified

[phenomlab]

@DownPW Yes, it’s not very elegant sadly, and there is an impact to other elements. You could write a jQuery function that only modifies the CSS when there are more than x of the same element in that div…

[DownPW]

Why not @phenomlab but like you know, i’m not a good JS develloper lol
I have not the skills for that

[DownPW]

@phenomlab do you think it is difficult to do?

EDIT: https://community.nodebb.org/post/88897

[phenomlab]

@DownPW said in nodebb chat roll dice game:

do you think it is difficult to do?

No, but judging by this

Loading...

Please wait while the description loads.

Loading...

It might be best to wait - or if you can’t, you could easily patch that file, or overwrite it (public/src/modules/helpers.common.js)

[DownPW]

@phenomlab said in nodebb chat roll dice game:

It might be best to wait - or if you can’t, you could easily patch that file, or overwrite it

ok but I don’t understand what the correction do for my problem ?

The interpretation of HTML is better ?

[phenomlab]

@DownPW yes, exactly. It’ll enable better element styling meaning a greater flexibility in terms of being able to target specific components

[DownPW]

I will test to see if it’s better out of curiosity but I don’t think that will be enough…

[DownPW]

That is what I thought. patching the file is not enough. Same result

[phenomlab]

@DownPW did you rebuild and restart after patching?

[phenomlab]

@DownPW from what I’ve read, the patch appears in core v2.5.0 and even then, this plugin would still need to be modified so that targeting classes is then available.

[DownPW]

Yes I see that and the correctif with type event ID