What is this bar called?

Panda

@phenomlab
As a design point, always a risk for bugs having duplicated data.
It would be better to just store score, and then get the icon from the table that stores icon cutoffs.

phenomlab

@Panda yes, that’s hard to argue. I’d just store numbers then use logic to determine which icon should be issued based on that.

However, I do see the reasoning for NodeBB’s approach s this was previously a community plugin and backwards completely of course has to be considered.

Panda

@phenomlab
Just my personal opinion, I wish it had been left as plugin. Im assuming from your comment Reputation code is core now?

I disabled this reputation on some forums. Have you seen the 10rules of how its calculated?
One of rules is something like:
by down-voting the object user loses x% subject to maxmin(5,50) and the subject loses y%, subject to criterias 1-10.
All sounded a bit complicated!
I am fundementally minimalist, so despite Flarums list of disadvantages, it has a clean start position.
NodeBB should be wary of throwing too much in as default and then ending up with bugs.
Just my opinion

phenomlab

@Panda yes, that’s why I disabled down voting here. If you don’t like a post, move on. Simple.

It’s still a plugin, but officially supported by NodeBB. The user level plugin doesn’t have any bearing on reputation. There is another plugin that exerts greater control over the reputation system and I think you might have that installed (as I do). From recollection, the core values are quite basic unless there’s something in the underlying code that would dictate otherwise?

phenomlab

@DownPW said in What is this bar called?:

Seems to be very good. Can you give code CSS & JS for that and I Can test ?

Of course - but beware as some of this code will be in use in the existing progress bar you have (specifically #pageup)

JS

$(document).on("click", "#pageUp", function(e) {
	const firstTopic = $('[component="category/topic"][data-index="0"]');
	if (firstTopic.length) {
		$("html, body").animate({
			scrollTop: 0
		}, '300');
	} else {
		ajaxify.refresh();
	}	
});

CSS

#pageUp {
  display: inline-block;
  background: var(--bs-body-component-active);
  width: 50px;
  height: 50px;
  text-align: center;
  border-radius: 0.375rem;
  position: fixed;
  bottom: 70px;
  right: 80px;
  transition: background-color .3s, opacity .5s, visibility .5s;
  opacity: 0;
  visibility: hidden;
}
#pageUp.show {
  opacity: 1;
  visibility: visible;
  z-index: 10000;
  color: var(--bs-body-navbar-color) !important;
}
a#pageUp.show:hover {
  background: var(--bs-dropdown-link-hover-bg);
  border: 1px solid var(--bs-border-color);
}
a#pageUp i {
    position: absolute;
    top: 32%;
    left: 35%;
}

@media (max-width: 767px) {
    #pageUp {
        bottom: 60px;
        right: 30px;
      }
    }

DownPW

Hi @phenomlab

Thanks for sharing

It’s the code for this reading bar :

In my point of view, it’s definitively better

DownPW

@phenomlab

It seems to be missing things because I don’t have the reading bar in the header and not have the button at the bottom right too

Could you provide me with the complete code in JS & CSS as if I was starting from scratch?

phenomlab

@DownPW Here you go. Remove any other references you have in custom JS that relate to the previous progress bar, and replace with this

// Scroll to top function
$(window).on('action:ajaxify.end', function(data) {
    var matched = false;
    $(document).ready(function() {
        var pageUp = $('#pageUp');
        var bar = $('.reading-meter');
        var perWidth = $('.reading-meter').width();
        
        // Main progressbar function
        function pageScroller() {
        var winScroll = document.body.scrollTop || document.documentElement.scrollTop;
        var height = document.documentElement.scrollHeight - document.documentElement.clientHeight;
        var scrolled = (winScroll / height) * 100;

        document.getElementById("progress-bar").style.width = parseFloat(scrolled).toFixed(0) + "%";
        $('#percentage').val(parseFloat(scrolled).toFixed(0) + "%");

        // Prevent the mouse scroll wheel from scrolling down after the pageUp button is clicked
        if ($('#pageUp').is(':focus')) {
        event.preventDefault();
        }
    }

        // Bind the pageScroller function to the window's scroll event
        $(window).scroll(function() {
            pageScroller();
        });

        // Check the URL and composer visibility separately from the scroll event
        $(window).scroll(function() {
            var thisURL = window.location.href;
            var checkURL = ["topic", "notifications", "user"];
            var isFound = false;
            for (var i = 0, len = checkURL.length; i < len; i++) {
                if (thisURL.indexOf(checkURL[i]) > -1) {
                    isFound = true;
                    break;
                }
            }
            if (isFound) {
                bar.removeClass('show');
                pageUp.removeClass('show');
            } else {
                // Exception here is that we don't want the scroll bar to show when the composer is active
                if ($(window).scrollTop() > 0 && (!$('[component="composer"]').is(":visible"))) {
                    bar.addClass('show');
                    pageUp.addClass('show');
                } else {
                    bar.removeClass('show');
                    pageUp.removeClass('show');
                }
            }
        });

        // Scroll to top when #pageUp is clicked
        $(document).on("click", "#pageUp", function(e) {
            const firstTopic = $('[component="category/topic"][data-index="0"]');
            if (firstTopic.length) {
                $("html, body").animate({
                    scrollTop: 0
                }, '300');
            } else {
                ajaxify.refresh();
            }	
        });
    });
});

Now in the custom header, remove the previous code that probably looks something like this

<div id="readingposition" class="reading-meter" style="bottom: 0px;">
    <div class="pageUp" id="pageUp"><i class="fa fa-angle-double-left pointer" aria-hidden="true"></i></div>
    <div class="pageDown" id="pageDown"><i class="fa fa-angle-double-right pointer" aria-hidden="true"></i></div>
    <div class="reading-meter-background rounded-1 border border-gray-300 ready">
    <div class="reading-meter-progress-bar rounded-1" id="progress-bar">
        <input disabled="disabled" type="text" id="percentage" name="percentage">
        </div>
  </div>  
  </div>

And replace with this

<a id="pageUp" class=""><i class="fas fa-chevron-up"></i></a>
<div id="readingposition" class="reading-meter" style="bottom: 0px;">
    <div class="reading-meter-background rounded-1 border border-gray-300 ready">
    <div class="reading-meter-progress-bar rounded-1" id="progress-bar">
        </div>
  </div>  
  </div>

Now use the CSS provided below (note, that you may have previous CSS that already exists if you used the older version of the progress bar - you should remove that)

#pageUp {
  display: inline-block;
  background: var(--bs-body-component-active);
  width: 50px;
  height: 50px;
  text-align: center;
  border-radius: 0.375rem;
  position: fixed;
  bottom: 70px;
  right: 80px;
  transition: background-color .3s, opacity .5s, visibility .5s;
  opacity: 0;
  visibility: hidden;
}
#pageUp.show {
  opacity: 1;
  visibility: visible;
  z-index: 10000;
  color: var(--bs-body-navbar-color) !important;
}
a#pageUp.show:hover {
  background: var(--bs-dropdown-link-hover-bg);
  border: 1px solid var(--bs-border-color);
}
a#pageUp i {
    position: absolute;
    top: 32%;
    left: 35%;
}
.reading-meter {
    position: fixed;
    width: 100%;
    top: 0;
    left: 0;
    right: 0;
    height: 2px !important;
}
.reading-meter {
    visibility: hidden;
}
.reading-meter.show {
    visibility: visible;
}


div#readingposition {
    background-color: var(--bs-body-navbar) !important;
    color: var(--bs-body-color) !important;
    height: 2px;
    z-index: 1000;
}

.reading-meter-progress {
    border: 1px solid var(--bs-border-color);
    width: 100%;
}

.reading-meter-background {
    background: var(--bs-body-bg);
}

.reading-meter-progress-bar {
    background: var(--bs-progress-bg-bar);
    height: 2px;
}
input#percentage {
    display: none;
}
 
@media (max-width: 767px) {
    #pageUp {
        bottom: 60px;
        right: 30px;
      }
    }

That should do it.

DownPW

Will test ASAP, i’m on new OGproxy conf now

DownPW

And where you put/replace this @phenomlab ? :

@phenomlab said in What is this bar called?:

And replace with this

<div id="readingposition" class="reading-meter" style="bottom: 0px;">
    <div class="reading-meter-background rounded-1 border border-gray-300 ready">
    <div class="reading-meter-progress-bar rounded-1" id="progress-bar">
        </div>
  </div>  
  </div>```

In the custom header I guess ?

DownPW

It seems to be worse. The JS no longer works.

When I remove the customJS and custom Header code. The website is OK

Could there be an error/omission in the given code? A typo in the code?

phenomlab

@DownPW strange. Is this on your dev server? I’ll take a look tomorrow morning.

DownPW

nope on my VM but you have an account on dev server

phenomlab

@DownPW ok. I’ll try it there tomorrow.

phenomlab

@DownPW said in What is this bar called?:

It seems to be worse. The JS no longer works.

When I remove the customJS and custom Header code. The website is OK

Could there be an error/omission in the given code? A typo in the code?

I must have been drunk or high on something else when I provided the code as there are large chunks of CSS missing, and a rogue closing parenthesis! That’s what too much work does I suppose

I’ve implemented the CORRECT version of this on your DEV site (tested ok) and updated the post so it reflects reality

DownPW

I thought something was missing…

I totally understand. Very tired me too at the moment and like you a lot of work provided between my job and the one done outside on PW

phenomlab

@DownPW said in What is this bar called?:

I totally understand. Very tired me too at the moment and like you a lot of work provided between my job and the one done outside on PW

Yes, that’s exactly the problem. Work is very demanding and has to come first, so I fit this (Sudonix) in whenever I can - often late into evenings and it’s easy to make even the simplest of mistakes

phenomlab

All - i found some bugs in the previous code that was posted, and have rectified the error. Please replace any code you are using with the revised version.

DownPW

@phenomlab

I don’t know why the reading-meter-progress-bar doesn’t appear on my smartphone (dev instance) when I scroll down but appear a little on scroll top ?

phenomlab

@DownPW That must be some sort custom CSS. I can’t reproduce that here. ,

What is this bar called?

JS

CSS

Did this solution help you?

Related Topics

NodeBB socket with CloudFlare

Why CSS acts different in Desktop?

adding some console.log to Nodebb

Footer bar add center text

Rotating homepage icons, gifs?

navigation bar is misplaced when the window gets smaller

Dark Theme Upper Padding

Reading Meter Progress bar

What is this bar called?

JS

CSS

Did this solution help you?

Related Topics

Individual Categories