Post Style View

[phenomlab]

@cagatay yep, I’ll take a look at this tomorrow and we’ll get it resolved.

[cagatay]

@phenomlab thank you waiting your free time

[phenomlab]

@cagatay Should look a bit better now - just finishing up the jQuery code as that is not firing properly. Let me know

[cagatay]

@phenomlab yes i entered new topic and new post, seems everything is working great. thanks Mark…

[phenomlab]

@cagatay Thanks for confirming. Just finishing up the jQuery functions so if you are logged in as admin, the page might reload a few times, but this is expected

[cagatay]

@phenomlab pls whatch it… https://www.veed.io/view/90c3e119-36d0-4687-a2c8-a2a48e038966?sharingWidget=true

[phenomlab]

@cagatay Seems fine to me ?

[cagatay]

@phenomlab pls refresh?

[phenomlab]

@cagatay I have. No issues on my side

[cagatay]

@phenomlab maybe it depends on me or my web browser. thank you

[phenomlab]

@cagatay No problems. I checked this in an incognito session also, with no issues

[phenomlab]

@cagatay said in Post Style View:

maybe it depends on me or my web browser. thank you

One thing I have noticed is that there are a number of errors on your site in the console. My concern here is that the jQuery functions I added are not being executed. For example, I removed the below function from your site about 30 minutes ago because it’s malformed

});ment).ready(function () {
    function animateTags() {
    	if (ajaxify.data.template.name === 'categories') {
    		var tags = $('.popular-tags .tag-item');
    		var bar = $('<div class="popular-tags-bar"></div>');
    		tags.append(bar);
    		
    		var max;
    		
    		setTimeout(function() {
        		tags.each(function() {
        		   var bar = $(this).find('.popular-tags-bar');
        		   var val = parseInt(bar.parents('a').find('.tag-topic-count').text(), 10);
        		   max = max > val ? max : val;
        		   
        		   bar.css({
        		       width: val / max * 100 + '%'
        		   });
        		});
    		}, 100)
    	}
    }
    animateTags();
    $(window).on('action:ajaxify.end', animateTags);
});

As you can see, this isn’t right at all. It should be

$(document).ready(function () {
    function animateTags() {
        if (ajaxify.data.template.name === 'categories') {
            var tags = $('.popular-tags .tag-item');
            var bar = $('<div class="popular-tags-bar"></div>');
            tags.append(bar);
 
            var max;
 
            setTimeout(function () {
                tags.each(function () {
                    var bar = $(this).find('.popular-tags-bar');
                    var val = parseInt(bar.parents('a').find('.tag-topic-count').text(), 10);
                    max = max > val ? max : val;
 
                    bar.css({
                        width: val / max * 100 + '%'
                    });
                });
            }, 100);
        }
    }
    animateTags();
    $(window).on('action:ajaxify.end', animateTags);
});

I’ve put this back how it should be, but am curious as to where that came from.

[cagatay]

@phenomlab i can not understand how it can be, i do not touch anything js side.

so now everything is working and code is okey hope so?

[phenomlab]

@cagatay Not entirely. There is an ajax call I need to use called action:ajaxify.loaded but this does not seem to be firing on your site. It’s opposite, action:ajaxify.end works fine (as you’ll see if you press F5) but the former does not, and I can’t see any reason as to why.

[cagatay]

@phenomlab maybe it depends on my nodebb version or really i can not say anything coz i don not know what is the ajax code as well

[phenomlab]

@cagatay Your NodeBB is up to date, so not an issue there. Just seems odd that no matter what I try, it doesn’t trigger. Investigating

[cagatay]

@phenomlab maybe there is a problem in my vps or ubuntu is not clearlu working or library etc…

[phenomlab]

@cagatay Not sure, but will check out a theory I have first before we go down that route.

[phenomlab]

@cagatay Found the issue. It appears that the hook I should be calling is in fact action:posts.loaded and not action:ajaxify.loaded

Should be fixed now but take a look. The best way to test this is to find a topic with lots of posts, and scroll to the bottom. Then, reload the page, and start scrolling up from the bottom to the top. As the new posts are added into the DOM, that function I wrote should execute and add the missing class

For anyone else following this thread, the two required jQuery functions are

    $(window).on('action:posts.loaded', function(data) {
        $(document).ready(function() {
        if ($('li[component="post"]').hasClass("")) {
            console.log("New posts detected,so adding classes for messenger type view");
            $('li[component="post"]').addClass('topic-response-post');
        }
    });
});
    $(window).on('action:ajaxify.end', function(data) {
        $(document).ready(function() {
        if ($('li[component="post"]').hasClass("")) {
            console.log("Adding required classes for messenger type view");
            $('li[component="post"]').addClass('topic-response-post');
        }
    });
});

[cagatay]

@phenomlab i checked topic with a lots of posts 3 times everything is clear and very well now. thank you your effort.