Threaded post support for NodeBB

[phenomlab]

Odd. Seems to work for me.

[DownPW]

nope it’s normal, i’m on 1080px height

[phenomlab]

@DownPW I’m going to reset your DEV password and login as you to check

[phenomlab]

I see why. Let me fix that

[phenomlab]

@DownPW can you log back into DEV and try again? Should be working now.

[phenomlab]

Here’s a video of the threading code working on stock Harmony on NodeBB.

However, it’s important to note that the timeline bar is removed and recreated. There is a good reason for this, as without taking this route, it would mean that the timeline bar will look out of place. It’s certainly possible to use the existing bar and use a variety of CSS to move it around, although this is VERY inconsistent in my testing, and lands up being far too complex when it comes to having multiple CSS classes that do not include a specific scenario etc.

In this case, it’s so much quicker to hide and replace the existing one - we do this in the default view also with the threaded view disabled, and I’m sure you won’t notice the difference For obvious reasons, this code is configured to only fire on displays of 1200px or more - obviously, firing on a mobile device wouldn’t look very good at all.

Here’s the video

If you like what you see, here’s the code.

Loading...

Please wait while the description loads.

Loading...

Final note - The code you see in the video is designed to work with stock Harmony. The code running on Sudonix is VERY different and uses a variety of CSS to render the view you see here. It’s “possible” to emulate this look, although it does mean that you will have to replace your custom CSS with that of Sudonix.

[mathourthy]

@phenomlab wow… that looks really cool. I need to fire up a NodeBB box and test.

[phenomlab]

NOTE: Minor bugfixes applied

Loading...

Please wait while the description loads.

Loading...

[crazycells]

this is very cool. Thanks @phenomlab

[DownPW]

Very cool like as already said above and a big thanks for hard work (I see the th function.js and woowwww )

I test it now and I have see this with plugin user-browsers :

Do you know where it could come from?

This also breaks the display of the site title

Can we do the same thing but without expanding the topic toolbar on header ?

---

EDIT :

I see that you seem put other things in the function.js on github like banner, logo, fancybox…
I said to myself that I found this file way too long without asking too many questions !

–> But I have the bug display with user browsers plugin which I will try to solve

[phenomlab]

@DownPW hmm. Not sure why I copied all of that code, but will change asap. I also have a fix for the browsing users plugin issue but didn’t include it because others might not be using it.

I’ll get to this as soon as I can.

EDIT - Done
EDIT 2 - I just noticed on your DEV box that you have (thanks to me - sorry) a ton of JS code you don’t need. You should probably clean that up.

[phenomlab]

@DownPW said in Threading support for NodeBB:

Can we do the same thing but without expanding the topic toolbar on header ?

Yes, but then you’ll have elements that are wider than the sticky bar which looks odd on scroll.

[phenomlab]

@DownPW said in Threading support for NodeBB:

Do you know where it could come from?

Yes, just fixed it in your dev environment. I assumed (probably incorrectly) that people may not have this installed, so omitted it. I fixed it in prod because I do have it there, but wanted to keep DEV as vanilla as possible.

I’ll need to write a function that checks for the existence of this plugin then determines where to inject the toggle switch

For now, see the below

$('.topic .sticky-tools ul .hidden-xs').append(threadView);
                // If you have browsing users plugin, comment out the above line and uncomment the one below
                //$('.topic .sticky-tools ul [component="topic/browsing-users"]:last-of-type').append(threadView);

Result (might need some position tweaking…)

[DownPW]

Good, thanks!!!
Test asap, i’m on intervention AT work

[DownPW]

@phenomlab said in Threading support for NodeBB:

EDIT 2 - I just noticed on your DEV box that you have (thanks to me - sorry) a ton of JS code you don’t need. You should probably clean that up.

no I need it

@phenomlab said in Threading support for NodeBB:

@DownPW said in Threading support for NodeBB:

Can we do the same thing but without expanding the topic toolbar on header ?

Yes, but then you’ll have elements that are wider than the sticky bar which looks odd on scroll.

Could you still explain to me how to obtain this result so that I can see what I prefer?

[phenomlab]

@DownPW said in Threading support for NodeBB:

Could you still explain to me how to obtain this result so that I can see what I prefer?

Yes, of course. Locate the below block in the CSS, and comment out margin-left: -8%;

  .topic .threaded.sticky-tools { 
     margin-left: -8%; 
     margin-top: 0px; 
     margin-bottom: 0px; 
     transition: margin-left 0.3s ease, margin-right 0.3s ease; 
   }

[DownPW]

Great, thank you Mark !

–> I also have a little suggestion to add a tooltip on the button mouse hover like "Thread view On and thread View Off depending on the state or maybe just one?

What do you think about it ?

[phenomlab]

@DownPW said in Threading support for NodeBB:

What do you think about it ?

Great idea. I’ll add that.

[DownPW]

maybe with an HTML SPAN class like this ?

<span class="title-tooltip top" tooltip-text="Thread View On">

[phenomlab]

@DownPW yes, that should work, although probably better to use one tooltip with on/off text.