New "messenger style" conversation view

[cagatay]

@phenomlab yes i know that is you i dont have dev but i think that you know my css and js type coz of fixed iframely.

[phenomlab]

@cagatay I do know it, yes, but this code contains breaking changes so I would not recommend for this to be deployed in live without thorough testing first. It’s possible to inject and test CSS code on the fly, but it’s not reliable and if the site is reloaded, you lose your changes.

You really should consider a DEV environment for things like this.

[cagatay]

@phenomlab got the point thank you.

[crazycells]

@phenomlab said in New "messenger style" conversation view:

@crazycells Do you mean in a messenger type view ? Yes, of course, but the conversation would all be one way woudn’t it ?

oh yes sorry, let me further explain what I meant…

In a normal NodeBB Persona theme, the main problem on pages containing posts lists such as:

/posts
/best
/controversial

is that avatar is forced to be on the right side of the page, and since the username and timestamp come after the avatar, there is a dead space created on the right side of the avatar on the mobile version of the website.

I was wondering if this re-ordering that you have just made with the messenger-style theme can be applied to these pages, so the username and timestamp can come before the avatar, just like how I see my posts on a regular thread here under this title…

I guess, in a sense, this is also compatible with your new theme since people will see their posts always with their avatar being on the right side of the page?

And on these posts list pages like /best , /controversial you look at your own posts lists anyways…

[crazycells]

by the way, we have to come up with another solution with the background of own posts… because this white background eliminates “quotes” as well… I cannot distinguish quotes in my post… Do you think keeping the gray border of the quote but not the background will solve the issue?

[crazycells]

on a side note… you are such a great person you should let us upvote you 20 times a day 6 is too low…

[phenomlab]

@crazycells heh, that limit is set by the extension and hard coded. Not by me I have to add.

[phenomlab]

@crazycells can you send me a screenshot ? I think I know what you mean - the quote background is close (or perhaps the same) as the reply background, yes ?

[crazycells]

@phenomlab said in New "messenger style" conversation view:

@crazycells can you send me a screenshot ? I think I know what you mean - the quote background is close (or perhaps the same) as the reply background, yes ?

here it is…

[phenomlab]

@crazycells can you reload the page (f5 refresh) and then from the swatch selector, choose the daylight theme and let me know what you see ?

That screenshot you sent doesn’t look like the swatch is fully loaded.

[crazycells]

@phenomlab said in New "messenger style" conversation view:

@crazycells can you reload the page (f5 refresh) and then from the swatch selector, choose the daylight theme and let me know what you see ?

That screenshot you sent doesn’t look like the swatch is fully loaded.

I reloaded the page and after selecting “Daylight” it looks like this:

but right after I reload the page again… the blue color goes away, and it becomes the “default” theme with no color distinction again…

[phenomlab]

@crazycells you shouldn’t need to reload the page? (At least, not a hard refresh)

[crazycells]

@phenomlab said in New "messenger style" conversation view:

@crazycells you shouldn’t need to reload the page? (At least, not a hard refresh)

yeah, what I mean is that the “daylight” does not stay on the page as the theme (a bug?), although the rest of the themes stay active when I reload the page.

[phenomlab]

@crazycells does this only happen with daylight ?

[crazycells]

@phenomlab said in New "messenger style" conversation view:

@crazycells does this only happen with daylight ?

Yes, I changed them one by one, it only happens with “daylight”.
Can you please send a screenshot of your page with the daylight theme?

[phenomlab]

@crazycells I think I see what you mean - do you see something like this, where the CSS does not appear to be applied?

Here’s where it gets interesting - I am using SCSS variable --self-post for this specific setting, and it does not seem to be applied

Notice the “–self-post is not defined”. And you are right - this only seems to be happening with the daylight theme, which is odd.

[phenomlab]

@crazycells I think I see the issue - it’s related to caching. Can you open sudonix.com in an incognito session, and let me know if you experience the same issue?

Either way, it’s something I need to fix.

[crazycells]

@phenomlab said in New "messenger style" conversation view:

@crazycells I think I see the issue - it’s related to caching. Can you open sudonix.com in an incognito session, and let me know if you experience the same issue?

Either way, it’s something I need to fix.

Yes, incognito session solves the issue

[phenomlab]

@crazycells thanks for confirming. Looks like I’ll need to write in a function that creates a random string meaning the css can’t be cached.

Interestingly, this same function was included in the original iteration I worked on for @DownPW but it was removed in this version because it wasn’t deemed necessary - but clearly is !

[phenomlab]

@crazycells This got the better of me over the weekend, so I decided to look into this a bit more. It’s not just caching, but the fact that NodeBB uses lazyLoad to prevent the DOM from being overloaded (this is why it is so fast). The issue here is that this specific view requires the injection of a new class to replace those that have none set.

As the DOM is already loaded, the required classes are not being added unless the page is being reloaded using the F5 key. Obviously, this is undesirable, so I’ve had to modify another function that I have which looks for lazyLoaded images added to the DOM on content update, then injects the fancybox function so that they can be handled in the same way as those already in the DOM.

Extending this function means the injection of required classes for those that are missing on lazyLoad is then possible. The function looks like the below

if (top.location.pathname !== '/login') {
    $(window).on('action:posts.loaded', function(data) {
        console.log("Polling DOM for lazyLoaded images to apply Fancybox");
        $(document).ready(function() {
            $('a').not('.forum-logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
                $('a[href*=".jpg"], a[href*=".jpeg"], a[href*=".png"], a[href*=".gif"], a[href*=".webp"]').addClass("noanimate");
            });
        });
/* This is where the messenger view type classes need to be injected if they are missing */
        $(document).ready(function() {
            if (!$('li[component="post"]').hasClass('.topic-owner-post') || (!$('li[component="post"]').hasClass('.self-post'))) {
                console.log("Adding required classes for messenger type view");
                $('li[component="post"]').addClass('topic-response-post');
 
            }
        });
    });
}

Arguably, it would be a much simpler affair if these classes existed in the core, but they sadly do not, so the above function is necessary.