Nodebb 3.2.0

[cagatay]

Hi Mark.

There is a problem after upgrading to v 3.2.0 on first post as below;

Post link is;

https://efelsefe.com/topic/1581/ölçmek

[phenomlab]

@cagatay Can you explain the issue in more detail? Apart from some minor CSS alignment, it’s not obvious.

[cagatay]

i think my css codes should be cleared.
vote area not working for example as for the first post.
and that photo was taken by andorid phone.

[phenomlab]

@cagatay In the console, I see Adding required classes for messenger type view which would have been a modified class that referred to the messenger type view I created for 1.x of the NodeBB software. As previously stated, it’s not valid for 3.x so will need to be removed.

I’ll login to your site now and take a look.

[cagatay]

@phenomlab thank you for your prompt response.

[phenomlab]

@cagatay No problem. Reload your site and test.

[cagatay]

yes, everything is okey now, but changed my icon for upvote and downvote

[phenomlab]

@cagatay Yes, you’ll need to set those back to what you want them to be.

I had to remove all of your CSS, and replace it with a working copy I have. This issue stems from new classes and viewports being introduced in 3.2.0 and because you had overriding classes from the previous 1.x version, it caused the issues you were experiencing.

The upside of this is that this CSS code is bleeding edge - the downside is that any customisations you made will need to be put back.

[cagatay]

thank you Mark.

[cagatay]

This post is deleted!

[DownPW]

For my part, since I upgraded to 3.2.0, the page takes longer to load than before and I see this socket error :

[phenomlab]

@DownPW can you try disabling Cloudflare and let me know if that resolves the issue?

[DownPW]

@phenomlab

If is here, already disable.

Same in incognito

if i disable OGproxy (ACP/custom JS), it’s better (more fast) but I have the error.

[phenomlab]

@DownPW OGProxy has no bearing on sockets. The only thing that could possibly slow down a reverse proxy is a slow DNS lookup. What happens if you change the DNS to (for example) 8.8.8.8 or 1.1.1.1 ?

Do you have any firewall device in between the internet and your server?

[DownPW]

@phenomlab

hmmm no and no. I have test on 2 diffèrent physical site (home and work)
Since upgrade, I haven’t constated this.

I haven’t this error on my VM in local (no domain)
I have deactivate proxied on DNS entry on Cloudflare = same

[phenomlab]

@DownPW I’ll have a look at this tomorrow. I assume this is your Dev server?

[DownPW]

Yes dev serv

[phenomlab]

@DownPW Just checked your site this morning. I see no slowness at all, and there are no socket errors for me

[crazycells]

hi @phenomlab , I think there is a bug on /groups page, “verified” group looks weird.

https://sudonix.org/groups

[phenomlab]

@crazycells yes, I’m aware of that. Need to fix

EDIT- fixed. Caused by the same CSS that is used to absolutely position the “verified” group badge in the posts view. Amended this CSS so that is specifically targets the post stream as below

    li[component="post"] a[href*="/groups/verified"] {
        position: absolute !important;
        left: 8px;
        z-index: 2;
        margin-top: 1px;
        border-radius: 999px !important;
        line-height: 14px;
        display: block;
        height: 22px;
        margin-left: 0px !important;
    }