nodebb-plugin-reactions not working @v1.0.2 with Harmony theme

[phenomlab]

@dave1904 hi David can you PM me your server details plus an account that has admin rights there and I’ll take a look.

[DownPW]

@dave1904

strange, works great on my development environment :

[dave1904]

@DownPW said in nodebb-plugin-reactions not working @v1.0.2 with Harmony theme:

@dave1904

strange, works great on my development environment :

There is something messed up with peer dependencies on my installation. @phenomlab is looking at it right now.

[DownPW]

Great, you’re in good hands

[DownPW]

If needed or if it can be used by someone using this plugin, here is my code for a dark theme :

/*----------------------------------------------------------------------------*/
/*----------------------     nodebb-plugin-reaction     ----------------------*/
/*----------------------------------------------------------------------------*/

/* Popup bg */
.emoji-dialog {
    border: 1px solid var(--bs-border-color);
    background: var(--bs-card-cap-bg);
}

/* Tab bg */
.nav-tabs .nav-item.show .nav-link, .nav-tabs .nav-link.active {
    --bs-nav-tabs-link-active-color: var(--bs-body-color-muted);
    --bs-nav-tabs-link-active-bg: var(--bs-body-navbar-active);
    --bs-nav-tabs-link-active-border-color: var(--bs-border-color);
}

/* Tab Hover */
.nav-tabs .nav-link:hover {
  border: var(--bs-nav-tabs-border-width) solid var(--bs-border-color);
}

/* Add reaction button */
span.reaction-add {
    color: var(--bs-link-color);
}

cya

[phenomlab]

@dave1904 I’ve managed to fix most of the peer dependencies but there are still some really strange issues with this instance. I need to look at this in a bit more detail unfortunately as it’s like trying to chase a ghost presently

What I am seeing is the below

npm WARN @apidevtools/swagger-parser@10.1.0 requires a peer of openapi-types@>=7 but none is installed. You must install peer dependencies yourself.
npm WARN @nodebb/nodebb-plugin-reactions@1.0.2 requires a peer of nodebb-plugin-emoji@^4.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN cosmiconfig-typescript-loader@4.3.0 requires a peer of cosmiconfig@>=7 but none is installed. You must install peer dependencies yourself.
npm WARN textcomplete.contenteditable@0.1.1 requires a peer of textcomplete@^0.14.2 but none is installed. You must install peer dependencies yourself.

The second line I would not expect because that dependency is satisfied by nodebb-plugin-emoji@5.0.7 which is now installed. Hard to know what the peer dependencies are currently.

EDIT: You have a really old npm version at 6.14.17. This should be upgraded and may solve the problems. For example, mine is v9.

Additionally, using the command
npm config set legacy-peer-deps true should auto resolve issues, but likely npm needs upgrading.

[dave1904]

@phenomlab I’m very thankful for taking your time and fixing most of the peer dependencies. That’s really strange

[phenomlab]

@dave1904 No issues. See my comment above about npm

[phenomlab]

@dave1904 I’ll look more into this tomorrow, but you could

1. Upgrade npm
2. Stop NodeBB
3. Run the NodeBB upgrade process again
4. Start NodeBB
5. Test

[dave1904]

@phenomlab said in nodebb-plugin-reactions not working @v1.0.2 with Harmony theme:

@dave1904 I’ll look more into this tomorrow, but you could

1. Upgrade npm
2. Stop NodeBB
3. Run the NodeBB upgrade process again
4. Start NodeBB
5. Test

I tried your steps but still no success unfortunately

[phenomlab]

@dave1904 what’s the output of npm --version and node --version ?

[dave1904]

@phenomlab

npm --version
9.6.5

node --version
v18.16.0

[phenomlab]

@dave1904 hmm. Nothing wrong with those.

[dave1904]

@phenomlab After upgrading npm and node I did upgrade nodebb again but that didn’t do any changes. Can you please tell me which commands I have to use to see those peer dependencies listed in the screenshot you sent me via pn?

[phenomlab]

@dave1904 if you stop NodeBB and use ./nodebb upgrade, they should appear in the console.

[dave1904]

2. Bringing base dependencies up to date...  started

up to date, audited 1180 packages in 8s

139 packages are looking for funding
  run `npm fund` for details

Looks better doesn’t it?

[phenomlab]

@dave1904 yes, it does.

[phenomlab]

@dave1904 did you manage to get any further with this ?

[dave1904]

@phenomlab I gave up on this yesterday

[phenomlab]

@dave1904 Ok. I’ll login again later and take a look at this. I still think it’s related to dependencies.