Switch between list and card view function

[phenomlab]

@DownPW said in Switch between list and card view function:

Too bad. I will therefore not be able to use this function or perhaps by just deleting the problematic avatar if that is possible

FIXED: Looks like I was using an incorrect hook have rectified that now, so can you please pull the latest functions.js and test?

harmony-card-view/functions.js at main · phenomlab/harmony-card-view

A card view for Harmony theme on NodeBB. Contribute to phenomlab/harmony-card-view development by creating an account on GitHub.

GitHub

[phenomlab]

I switched my domain back to CF, and all the previous bugs came back However, I’ve re-written the code to use custom CSS instead of external CSS, and this so far looks good in test. I want to evaluate this a bit more before I release the updated code, but so far, this looks like it’s going to work.

[phenomlab]

@DownPW I think I might finally have it - code that works in CF with no bugs…

Can you please test this code (which is running in sudonix.dev) and let me know what you think? It’s not ready for publish just yet but will be once I’ve tidied up a few things.

[DownPW]

Hello Mark

It looks pretty good on your test platform. I didn’t notice the bug there.

Let’s see what it looks like on another server with CF.

[phenomlab]

@DownPW Great. There is still one small bug I noticed, but I think that might be a caching issue. This new code is refactored, and has structurally changed. I’ll post the new code in the main topic, plus updated instructions.

[phenomlab]

After a significant rewrite of the code plus the CSS, I’m pleased to release this stable version. There are some changes however.

1. The external CSS file is no longer needed (you can delete it). As a result, the CSS you see in the below file needs to be copied into

/admin/appearance/customise#custom-css

harmony-card-view/card.css at main · phenomlab/harmony-card-view

A card view for Harmony theme on NodeBB. Contribute to phenomlab/harmony-card-view development by creating an account on GitHub.

GitHub

2. The JS code has been refactored, and the code contained in the link below needs to be copied into

/admin/appearance/customise#custom-js

You need to overwrite existing code if you have it

harmony-card-view/functions.js at main · phenomlab/harmony-card-view

A card view for Harmony theme on NodeBB. Contribute to phenomlab/harmony-card-view development by creating an account on GitHub.

GitHub

IMPORTANT

If you use Cloudflare, you MUST disable the HTML minification if you use it

If everything went well, you should see this

If it doesn’t look like the above, the main reason for this is that you are using Cloudflare and have not disabled HTML minification. If this setting is enabled, the JS code will insert additional classes into the DOM as it should, although CF has a bad habit of changing the execution order meaning the CSS is not correctly applied to the first set of returned topics - an example of that below

If you experience this issue, please ensure that you’ve disabled HTML minification.

Enjoy the new layout. Any issues, let me know.

[DownPW]

Test ASAP this version on my dev environment with CF my friend.
Thank you so much

[DownPW]

Still doesn’t work for me

I’m in DNS only mode in CF,

I deactivated CF and it’s the same :

I deleted all my custom CSS and JS on nodebb ACP, leaving only those for the card view and I have the same problem.

I admit that I don’t understand anything anymore.

[phenomlab]

@DownPW I think I see why.

Can you locate this css block

.category-card .lastpost a img {
    margin-top: 10px;
    margin-left: -185px;
}

and change it to

.category-card .lastpost a img, span.avatar.avatar-tooltip.not-responsive.avatar-rounded {
    margin-top: 10px;
    margin-left: -178px;
}

I did not account for the usage of standard avatars (the ones were it uses the first letter of the username) - I use a custom “guest” or “no upload” image defined here

Whereas your site doesn’t have this and therefore replaces the CSS class which we have not previously targeted

I’m confident that this will resolve the issue (famous last words)…

[DownPW]

I’m with my childs, test asap

[phenomlab]

@DownPW I see you set a default avatar ?

On checking your site, this has resolved the issue, but you should still have that CSS I defined above. As soon as you validate, I will add this to the code.

[DownPW]

@phenomlab said in Switch between list and card view function:

Can you locate this css block

.category-card .lastpost a img { margin-top: 10px; margin-left: -185px;}
and change it to

.category-card .lastpost a img, span.avatar.avatar-tooltip.not-responsive.avatar-rounded { margin-top: 10px; margin-left: -178px;}
I did not account for the usage of standard avatars (the ones were it uses the first letter of the username) - I use a custom “guest” or “no upload” image defined here

Whereas your site doesn’t have this and therefore replaces the CSS class which we have not previously targeted

I’m confident that this will resolve the issue (famous last words)…

Seems to work

So actually all the avatars where the problem occurs are account avatars which have no profile image (very good remark)

If i set default avatar, the bug is resolved.

[phenomlab]

@DownPW Yes, but it’s not a “bug” - it’s something I didn’t consider during the design, but the updated CSS will address that. Glad it works!!

Updated CSS committed.

Update card.css · phenomlab/harmony-card-view@f0d95ff

A card view for Harmony theme on NodeBB. Contribute to phenomlab/harmony-card-view development by creating an account on GitHub.

GitHub

[DownPW]

Yes, I completely understand what you mean.

Finally the first code should work but it’s a blessing in disguise. I think the no external stylesheet approach is much better.

[phenomlab]

@DownPW said in Switch between list and card view function:

I think the no external stylesheet approach is much better.

Yes it’s better to have it all in one place, but the custom css is not minified so not optimised out of the gate. Easy to address but if you frequently change css then you’d have to reverse the minify each time to make what you have readable.

[DownPW]

oh yeahh, actually I hadn’t thought about that

[DownPW]

I notice this my friend whe we use this css:

.category-card .lastpost a img, span.avatar.avatar-tooltip.not-responsive.avatar-rounded {    
    margin-top: 10px;    
    margin-left: -178px;
}
 

with no default avatar on ACP (OK with default avatar on ACP)

[phenomlab]

@DownPW that’s odd. I’ll need to check that. When I looked at your dev server earlier with the default avatar left blank, I used the custom css which worked fine.

[phenomlab]

My bad. That should be

.category-card .lastpost a img, .category-card span.avatar.avatar-tooltip.not-responsive.avatar-rounded {    
    margin-top: 10px;    
    margin-left: -178px;
}

[DownPW]

Hi,

seems to broke Users display