[NODEBB] Help for my custom CSS

phenomlab

@DownPW strange. Fancybox doesn’t actually alter the image as far as I recall.

Does it make a difference if you change the class name (in developer mode) from fancybox to say, fancybox1?

If it works, then the class may have that defined already.

DownPW

@baris said:

You should change your selectors so it doesn’t look at the entire document. You probably only want to apply fancybox to stuff inside the #content element which is what changes when the user navigates around the page. So use $('#content a').... for your selectors then the forum logo in the header won’t be selected.

I modified the JS Fancybox code now and this code and it seem better

// ---------------------------------------------
// Fancybox Media Reader (Without Website Logo)
// ---------------------------------------------

if (top.location.pathname !== '/login') {
    $(window).on('action:posts.loaded', function(data) {
        console.log("Polling DOM for lazyLoaded images to apply Fancybox");
        $(document).ready(function() {
            $('#content a').not('.forum-logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
                $('#content a[href*=".jpg"], #content a[href*=".jpeg"], #content a[href*=".png"], #content a[href*=".gif"], #content a[href*=".webp"]').addClass("noanimate");
            });
        });
    });
}

if (top.location.pathname !== '/login') {
    $(document).ready(function() {
        $(window).on('action:ajaxify.end', function(data) {
            $('#content a').not('.logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
                $('#content a[href*=".jpg"], #content a[href*=".jpeg"], #content a[href*=".png"], #content a[href*=".gif"], #content a[href*=".webp"]').addClass("noanimate");
                data.preventDefault()
                // Strip out the images contained inside blockquotes as this looks nasty :)
                $('#content blockquote img').remove();
            });
            Fancybox.bind(
                '#content a[href*=".jpg"], #content a[href*=".jpeg"], #content a[href*=".png"], #content a[href*=".gif"], #content a[href*=".webp"]',
                {
                    groupAll: true,
                }
            );
        });
    });
}

// Chat fancybox - fires when chat module loaded and AJAX calls new chat
$(document).ready(function() {
    $(window).on('action:chat.loaded', function(data) {
        // >>> Se limiter au contenu principal uniquement <<<
        $('#content img').not('.forum-logo').not(".avatar").not(".emoji").not(".bmac-noanimate").each(function() {
            var newHref = $(this).attr("src");
            $(this).wrap("<a class='fancybox' href='" + newHref + "'/>");
            $('#content a[href*=".jpg"], #content a[href*=".jpeg"], #content a[href*=".png"], #content a[href*=".gif"], #content a[href*=".webp"]').addClass("noanimate");
            data.preventDefault();
            // Strip out the images contained inside blockquotes as this looks nasty :)
            $('#content blockquote img').remove();
        });
        Fancybox.bind(
            '#content a[href*=".jpg"], #content a[href*=".jpeg"], #content a[href*=".png"], #content a[href*=".gif"], #content a[href*=".webp"]',
            {
                groupAll: true,
            }
        );
    });
});

For the logo, I must use overflow: visible !important; on [component="brand/logo"]

/* --- Logo --- */
[component="brand/logo"] {
  max-height: 50px;
  width: auto;
  height: auto;
  max-width: 100%;     
  display: block;
  object-fit: contain;  
  object-position: left center;
  overflow: visible !important;
}

Better result !!

cagatay

Since the latest update, all my icons have disappeared. Could you please advise how to restore them?

DownPW

You use custom version of Font Awesome ?

cagatay

yes @downpw

DownPW

@cagatay said:

yes @downpw

So is taht the problem.
The core migrated to FA6 and no longer automatically includes the compatibility layers. The all.css alone is no longer enough because it only loads icons in native FA6 syntax (fa-solid, fa-regular, etc.). Your old icons using FA4 syntax (fa fa-something) are no longer recognized without the shims.

Hence the need for the three files:

all.css: the FA6 icons themselves
v4-shims.css: the mapping table that remaps the old FA4 names to their FA6 equivalents (many icons were renamed between FA4 and FA6)
v4-font-face.css: redeclares the FontAwesome @font-face with the old family names (FontAwesome instead of "Font Awesome 6 Pro"), so CSS selectors targeting the old font-family keep resolving

So if your customs still use FA4 syntax, all three are required.

I load my Custom FA like this in my ACP/Headers :

<link href="/assets/customfonts/FontAwesome.Pro.6.x.x/css/all.css" rel="stylesheet" />
<link href="/assets/customfonts/FontAwesome.Pro.6.x.x/css/v4-shims.css" rel="stylesheet" />
<link href="/assets/customfonts/FontAwesome.Pro.6.x.x/css/v4-font-face.css" rel="stylesheet" />

cagatay

how i create those folders. i added ACP/HEADERS the codes but not working.

DownPW

@cagatay said:

how i create those folders. i added ACP/HEADERS the codes but not working.

Adapt path to your custom installation. I don’t know where is your custom FA Folder nor how you use it

DownPW

You need to load your Font Awesome CSS files by adjusting this code to the path where you saved them.

But honestly, I don’t know how you’ve configured your site in this regard.

cagatay

what i have now

[NODEBB] Help for my custom CSS

Did this solution help you?

Related Topics

NodeBB socket with CloudFlare

Upgrade to NodeBB v3? 2BB or not 2BB, that is the question!

NodeBB: Privileges for the Announcement channel

Top Ranked Forums

[NodeBB] Import custom Font

[NodeBB] username cards

nodebb-plugin-customize error

NodeBB Design help

[NODEBB] Help for my custom CSS

Did this solution help you?

Related Topics

Individual Categories