Threaded post support for NodeBB

[phenomlab]

@DownPW said in Threading support for NodeBB:

cache maybe. I have delete the bugfix because not bug fix

Yes, I can’t reproduce this.

[DownPW]

I mean bug is present but my bug fix don’t work properly.

test to delete my cache and tell you

[DownPW]

@phenomlab not cache

[phenomlab]

@DownPW PM me the link to the post.

[DownPW]

actually, I noticed that it’s not on all the posts.
it seems that these are the posts where the last response is that of the user (selfpost)

DONE

[phenomlab]

@DownPW I’ll have a look at this later

[DownPW]

no problem.
I have resolve this bug with change/replace this CSS CODE (I have just delete transform directive) :

li.pt-4.self-post:not(.self-post .topic-owner-post).threaded {
   /*transform: translateX(0px) !important;*/
   transition: transform 0.3s ease !important;
   background: var(--bs-body-bg);
   background: var(--bs-body-navbar)!important;
   padding-right: 30px;
   margin-left: 0rem;
   padding-bottom: 0rem !important;
 }

I don’t know if is a goodfix or not.

[phenomlab]

@DownPW yes, was just typing that!

[DownPW]

ha ha

[phenomlab]

Quick note here for anyone who is using the Threaded Posts code and has recently upgraded to 3.7.0 - only to find the threaded posts is now broken

This is being caused by the HTML structure changes that 3.7.0 makes in the DOM, meaning the element we used to target pre this release no longer exists. To resolve this, locate the line (within the threaded JS function)

$('.topic .sticky-tools ul.list-unstyled').append(threadView);

And replace it with

$('.topic .sticky-tools .thread-tools').append(threadView);

That should make it re-appear.

[cagatay]

Mark hi,
I dont have this code in my js functions.

[phenomlab]

@cagatay Yes, because you have legacy code. The line you have is this

$('.topic .sticky-tools ul [component="topic/browsing-users"]:last-of-type').append(threadView);

This will work fine because you are using the browsing users plugin, but should you decide to remove it, the threaded utility will cease to function. I’ve replaced that line with the below on your forum.

$('.topic .sticky-tools .thread-tools').append(threadView);

[phenomlab]

Updated git for above change

https://github.com/phenomlab/nodebb-harmony-threading/commit/14a4e277521d83d219065ffb14154fd5f5cfac69