NodeBB Twitter / X embeds

[DownPW]

As usual : very good work my friends
I’m going on vacation for a week so I’ll try this later

[DownPW]

Tested.
It seem embed is on a blockquote.
I play with this class blockquote.content.twitter-tweet for better résult (transparency of blockquote)

I notice it seems the beginning of URL appears (https://)

Result int the screenshot :

cya

[phenomlab]

@DownPW strange. I’m not able to replicate these specific issues. Can you provide me with the url of the tweet in a PM so I can test?

Thanks

[cagatay]

great work thank you Mark.

[OT]

This is how it shows up for us. Just have the random dupes of the same tweet. Of course, users are complaining of seeing a tweet repeat three times, but they quickly forgot that a tweet was just showing the X.com using Iframely or any other plugin.

[phenomlab]

@OT can you post the actual tweet url ?

[JAC]

I’ve had it where a tweet will show twice but once the page has been refreshed it’ll show the one again.

[phenomlab]

Updated code to address the duplicate tweet issue

nodebb-twitter-embeds/embeds.js at main · phenomlab/nodebb-twitter-embeds

NodeBB Twitter Emdeds. Contribute to phenomlab/nodebb-twitter-embeds development by creating an account on GitHub.

GitHub

[Madchatthew]

@phenomlab That is awesome, great job!

[OT]

Have you experienced that some posts will not show up after they have been posted, or that the post will look greyed out? This goes away if you refresh the page.

[phenomlab]

@OT Not seen this personally. Are you using the latest commit?

[DownPW]

An exemple of tweet don’t embed with last code @phenomlab

Loading...

Please wait while the description loads.

Loading...

EDIT:

Strange, work here but not on my forum:

Other tweets works great

Mistery

[phenomlab]

@DownPW Are you sure you’re using the latest commit?

[phenomlab]

@DownPW said in NodeBB Twitter / X embeds:

EDIT:

Strange, work here but not on my forum:

Just looking at this again, and it seems that SaxX in the URL is written as SaxX - was that intentional?

[DownPW]

@phenomlab said in NodeBB Twitter / X embeds:

Just looking at this again, and it seems that SaxX in the URL is written as SaxX - was that intentional?

I don’t know. I guess but that doesn’t explain that working here and not on my forum… hmm

URL:

Itt seems on my forum the “_” character was delete in the URL (Don’t know why) :

[phenomlab]

@DownPW Can you PM me the link to prod so I can have a look?

[phenomlab]

@DownPW There appears to be a space inserted in the URL?

Note, after the / where it is formatted as / SaxX/

[DownPW]

hmm not on my screen :

but “_” dissapear

[phenomlab]

@DownPW Can you grant my login temporary admin?

[phenomlab]

@DownPW I see the issue. The URL has underscores present

This basically means that the composer sees this as Markdown and is attempting to render it as such. It’s not a bug in the X embed code. I may be able to work around it though.