Switch between list and card view function

[phenomlab]

@cagatay Yes, that’s a bug. It’s going to be just CSS, so will issue a fix shortly.

[phenomlab]

@cagatay Fixed. Not with CSS as I planned, but with an updated function

Update functions.js · phenomlab/harmony-card-view@e2ae2e5

Bugfix to prevent subcategories being rendered as card view

GitHub

This should be used to replace the existing function(s) you have in /admin/appearance/customise#custom-js

Full code here

harmony-card-view/functions.js at main · phenomlab/harmony-card-view

A card view for Harmony theme on NodeBB. Contribute to phenomlab/harmony-card-view development by creating an account on GitHub.

GitHub

[cagatay]

worked thank you Mark.

[crazycells]

Hi Mark, I am having some bugs on my laptop screen (Firefox , OS 13.6.4) , fyi…

[phenomlab]

@crazycells thanks. What resolution are you running?

[crazycells]

@phenomlab ~1285 px

[phenomlab]

@crazycells thanks. I’ll need to check this

[phenomlab]

@crazycells Thanks for reporting this. It’s fixed here, and should look like the below (you’ll need to reload the browser)

This uses customised CSS when this viewport size is detected, and also needs to remove one of the tags to prevent them spilling out of the DIV

    [component="topic/tags"] a:nth-child(2) {
        display: none;
    }

It’s a bit of a hack, but necessary to accommodate this screen size. Let me know if it looks good and I’ll commit it.

[crazycells]

@phenomlab can you please check the borders agains? I think it is going well up until ~1290 px, but then, it is disrupted, and it is fixed again after ~1400 px

[phenomlab]

@crazycells hmm. Thought that might happen. Let me have a look.

[phenomlab]

@crazycells said in Switch between list and card view function:

can you please check the borders agains? I think it is going well up until ~1290 px, but then, it is disrupted, and it is fixed again after ~1400 px

Should be resolved now? Obviously, no site will cater for odd browser sizes or screen resolutions - that’s not a realistic expectation, but the issue you reported should be fixed.

[crazycells]

@phenomlab yes, it is fixed now

[phenomlab]

@crazycells thanks. I’ll commit the updated css code over the next few days.

[phenomlab]

Loading...

Please wait while the description loads.

Loading...

[crazycells]

hi @phenomlab , there is a bug when there is no reply on the topic… it says “no one has replied” but when the title is spanning two lines, then it overlaps… please see below…

[phenomlab]

@crazycells ok, thanks. I thought that might happen. Will resolve later.

EDIT - just done it. It’s a bit rough perhaps as done in a hurry!

[phenomlab]

@crazycells